CI: fix pr-code-format #5163
Merged
CI: fix pr-code-format #5163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crueter
force-pushed
the
fix-pr-format
branch
2 times, most recently
from
fe9027a to
bfba335
Compare
crueter
force-pushed
the
fix-pr-format
branch
from
5a0d192 to
144fcbe
Compare
Contributor
Author
|
did some final cleanups, should be good now |
Member
|
@pmatos Could you take a look at this? |
Collaborator
Yep. Give me a couple of hours. |
pmatos
reviewed
Jan 13, 2026
pmatos
suggested changes
Jan 13, 2026
Previously, changes to externals were also tracked, resulting in absolutely hilarious abominations like https://github.com/FEX-Emu/FEX/actions/runs/20498228017/job/58901276463?pr=5162 So rather than dealing with that weird action, just fetch the main branch and run a `diff --name-only` with the PR's merge base with main. This is how I've done several dozen diff-based scripts (license headers, clang-format, etc) and it works perfectly, so let's just use this. Should run quicker too but don't put any money on it. I also went ahead and removed a bunch of unnecessary quotations cuz wynaut. Signed-off-by: crueter <[email protected]>
crueter
force-pushed
the
fix-pr-format
branch
from
144fcbe to
96b8904
Compare
Collaborator
|
@crueter looks good. this is hard to test locally. Lets hope it holds up in practice. Thanks. |
Collaborator
|
@crueter you might have to re-request a review so I can formally approve it. Weird github flow. |
Contributor
Author
|
augahahhhhaghha |
Sonicadvance1
approved these changes
Jan 15, 2026
Member
Sonicadvance1
left a comment
Sonicadvance1
left a comment
There was a problem hiding this comment.
Well if @pmatos says it's okay, then sure, let's see if it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, changes to externals were also tracked, resulting in
absolutely hilarious abominations like https://github.com/FEX-Emu/FEX/actions/runs/20498228017/job/58901276463?pr=5162
So rather than dealing with that weird action, just fetch the main
branch and run a
diff --name-onlywith the PR's merge base with main.This is how I've done several dozen diff-based scripts (license headers,
clang-format, etc) and it works perfectly, so let's just use this.
Should run quicker too but don't put any money on it.
I also went ahead and removed a bunch of unnecessary quotations cuz
wynaut.
Signed-off-by: crueter [email protected]